Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate into ICU4X tree #56

Closed
Manishearth opened this issue Dec 14, 2021 · 5 comments
Closed

Migrate into ICU4X tree #56

Manishearth opened this issue Dec 14, 2021 · 5 comments

Comments

@Manishearth
Copy link
Collaborator

Manishearth commented Dec 14, 2021

Currently tinystr both depends on crates from ICU4X (zerovec) and is depended on by crates from ICU4X (a lot of them). This means that any time zerovec has a breaking change, we need to do a three-step update across repos. At the moment we can do this piecewise, but the moment ICU4X starts using tinystr with the zerovec feature enabled it's going to get worse because it will not be possible to land these changes in the ICU4X tree without doing a pair of cargo publishes first

As the group of people merging to this repo is ICU4X contributors anyway, we should probably just move it into utils/ where it can live alongside zerovec and yoke.

A slight hitch is that this crate is currently Apache/MIT dual licensed, whereas all crates in the ICU4X repo are mandated in having a LICENSE file that states that they are Apache/MIT with ICU/Unicode license applied in places where marked. For this crate, this license file would basically just be stating "this code is Apache/MIT" since we do not have any place where we mark code taken from ICU. We're discussing relaxing some of the requirements here in unicode-org/icu4x#1358, but if we don't want to wait for that issue to be fixed, here's what I propose:

  • This crate be moved into ICU4X utils/
  • The ICU4X LICENSE file is added, however the Cargo.toml stays unchanged and continues to say MIT OR Apache-2.0
  • We can delete LICENSE-APACHE and LICENSE-MIT if desired since their text is contained in the ICU4X license

Thoughts? @sffc @zbraniecki

@Manishearth
Copy link
Collaborator Author

Manishearth commented Dec 14, 2021

This blocks zero-copy japanese era data (part of unicode-org/icu4x#1116) since that uses TinyStr

@zbraniecki
Copy link
Owner

I'd love to donate this crate to ICU4X.

@Manishearth
Copy link
Collaborator Author

¹not tax-deductable

@sffc
Copy link
Collaborator

sffc commented Dec 14, 2021

I scheduled the ICU4X Licensing Discussion for December 20.

@Manishearth
Copy link
Collaborator Author

This was done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants