Implementation of Pallas #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
reviewed
Mar 26, 2021
|
This PR now just covers the Pallas implementation. Test vectors are in subsequent PRs like #17. |
daira
reviewed
Apr 20, 2021
Co-authored-by: Daira Hopwood <[email protected]>
ebfull
approved these changes
Apr 21, 2021
Comment on lines
+141
to
+144
| def __init__(self, x, y): | ||
| self.x = x | ||
| self.y = y | ||
| self.is_identity = False |
There was a problem hiding this comment.
Would be cool to have an is_on_curve assertion here; y^2 == x^3 + b.
| assert Point.ZERO + Point.ZERO == Point.ZERO | ||
| assert Point.GENERATOR - Point.GENERATOR == Point.ZERO | ||
| assert Point.GENERATOR + Point.GENERATOR + Point.GENERATOR == Point.GENERATOR * Scalar(3) | ||
| assert Point.GENERATOR + Point.GENERATOR - Point.GENERATOR == Point.GENERATOR |
There was a problem hiding this comment.
A good test is assert (-Point.GENERATOR) == Point.GENERATOR * -Scalar(-1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.