Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSX comment stopped working in html tags #16337

Closed
1 task done
Tsolmonx opened this issue Aug 16, 2024 · 6 comments
Closed
1 task done

TSX comment stopped working in html tags #16337

Tsolmonx opened this issue Aug 16, 2024 · 6 comments
Labels
bug [core label] html HTML markup support language An umbrella label for all programming languages syntax behaviors regression A bug that was introduced in a recent release tsx TypeScript JSX support typescript TypeScript programming language support

Comments

@Tsolmonx
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When i try to comment the code in tsx html tags it comment with double slash. It used to work before with right comment in html tags now its all //.

Environment

image

If applicable, add mockups / screenshots to help explain present your vision of the feature

image

If applicable, attach your Zed.log file to this issue.

Zed.log
@Tsolmonx Tsolmonx added admin read bug [core label] labels Aug 16, 2024
@SomeoneToIgnore
Copy link
Contributor

I believe this happens due to tree-sitter/tree-sitter-typescript#306 and the corresponding update to the newer tree-sitter-typescript crate in Zed that we had to do at some point.

@Moshyfawn Moshyfawn added regression A bug that was introduced in a recent release typescript TypeScript programming language support language An umbrella label for all programming languages syntax behaviors and removed triage labels Aug 18, 2024
@mrvfino
Copy link

mrvfino commented Aug 19, 2024

Experiencing this as well, i thought i just broke something in my config. @Tsolmonx , did you find any temporary solution?

@m1guer
Copy link

m1guer commented Aug 27, 2024

any update?

@animify

This comment has been minimized.

@Edgarfp
Copy link

Edgarfp commented Oct 23, 2024

I think it has been fixed in latest version. I tested it and it's working fine.

@mikayla-maki
Copy link
Contributor

Closed from: #17734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] html HTML markup support language An umbrella label for all programming languages syntax behaviors regression A bug that was introduced in a recent release tsx TypeScript JSX support typescript TypeScript programming language support
Projects
None yet
Development

No branches or pull requests

9 participants