Add static Runnables #8009

osiewicz · 2024-02-19T10:30:08Z

Partially addresses #7108 .

This PR includes just the static runnables part. We went with not having a dedicated panel for runnables.
This is just a 1st PR out of N, as we want to start exploring the dynamic runnables front. Still, all that work is going to happen once this gets merged.
TODO:

docs
Schema support in runnables definition file.
Use serde_json_lenient parser.

Release Notes:

Added Runnables support to Zed. Runnables are defined in runnables.json file (accessible via zed: open runnables action) and they can be spawned with runnables: spawn action.

co-authored-by: Pitor <[email protected]>

Co-authored-by: Beniamin <[email protected]>

Try to use the cwd from runnable definition first, and if it's absent, fallback to the current project's cwd detection and even if it fails, move on with runnable's execution.

crates/project/src/project.rs

crates/project/src/runnable_inventory.rs

crates/project/src/terminals.rs

crates/runnable/src/static_runnable.rs

crates/terminal_view/src/terminal_panel.rs

…itialisation

SomeoneToIgnore · 2024-02-19T16:28:57Z

cc @mikayla-maki as you were interested in the terminal part.
Will merge this optimistically, but please send the feedback if you find something interesting.

osiewicz and others added 30 commits January 30, 2024 12:14

Add runnable crate

e0b07ca

fixup! Add runnable crate

2d076cf

Add more to the runnables crate

c6a1838

co-authored-by: Pitor <[email protected]>

Wire the static task execution through.

a4c0f08

Co-authored-by: Beniamin <[email protected]>

Fix infinite recursion in poll impl

ac3b682

Make task running/cancellation sorta work

d04520c

Add id to Runnable trait

1ee2f6e

Start work on runnable inventory

3463788

Sketch out Source trait

e02d086

Start fleshing out the StaticSource

d0db6c8

Draft reacting on the settings change

b98ef36

Push file tracking forward

4336f97

Don't observe Project Views, that's silly

32294cf

Add RunFirstAction action, improve state tracking

be128f5

Remove 'Done' state, change RunFirstAction to RunActionWithName

0887de4

Merge branch 'main' into runnables

fad9700

Add runnables_panel crate

81b0638

Start sketching out filter in a panel

9e0a55b

Notify whenever static definitions change, render runnables in list

2c9b08b

Bookkeeping

b068a70

Merge branch 'main' into runnables

514b41c

Merge branch 'main' into runnables

3150144

Make runnables panel react to setting changes

ea7ac9b

Change icon of runnables panel to Play

2e31d45

Wire through panel serialization

e2ec73d

Wire through collapsed_icon_color for panel

4c62387

Simplify ID situation in sources/runnables

3a144df

Tweak list appearance

d952113

Keep focus in runnables panel

f60bebb

Prepare to print commands' output

5a1c3de

Document runnables, respect their env and cwd settings.

1b8a397

cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 19, 2024

osiewicz changed the title ~~Add Runnables~~ Add static Runnables Feb 19, 2024

SomeoneToIgnore and others added 3 commits February 19, 2024 12:45

Never fail when determining runnables' cwd

fe8cc2c

Try to use the cwd from runnable definition first, and if it's absent, fallback to the current project's cwd detection and even if it fails, move on with runnable's execution.

Add JSON schema for runnables, use lenient json parser

fda83e9

Fix clippy

81d6c41