Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline colors not working on Window Terminal #3262

Open
mmgeorge opened this issue Apr 14, 2024 · 7 comments
Open

Underline colors not working on Window Terminal #3262

mmgeorge opened this issue Apr 14, 2024 · 7 comments

Comments

@mmgeorge
Copy link

mmgeorge commented Apr 14, 2024

1. Graphical issue inside a terminal pane (eg. something does not look as it should)

zellij --version: zellij 0.39.2
(I also tried checking out 7f87d93a430a47c82ce3f177a6a2609d3f6abadeand & saw the same thing)

stty size: 56 120

uname -av or ver(Windows): Linux mgeorge 5.15.146.1-microsoft-standard-WSL2 #1 SMP Thu Jan 11 04:09:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Further information

Undercurls are working great, but I seem to be hitting some problems with underline colors in WSL + Window Terminal 1.19/1.20:

echo -e "\x1b[58:5:32m\x1b[4mtest\x1b[59m\x1b[24m"
echo -e "\x1b[4:3mTest\x1b[24m "

win-term-default

image

@steakhutzeee
Copy link

steakhutzeee commented May 6, 2024

How undercurls should be enabled for Zellij in Windows Terminal?

I can see them in Neovim on tmux by a terminal override, but not in Zellij.

Any hint?

@mmgeorge
Copy link
Author

mmgeorge commented May 7, 2024

@steakhutzeee for me they work on the latest version without any additional configuration, just the colors that aren't working for me

@steakhutzeee
Copy link

With your commands they work for me too. It's in nvim that they are now working.
I was able to let them work inside tmux but not outside with a terminal override. Any idea how to do this with Zellij?

@mmgeorge
Copy link
Author

mmgeorge commented May 8, 2024

Sorry @steakhutzeee I'm not sure what would be causing them to work in tmux but not zellij. On my end at least they just work by default with the latest zellij.

@achkasov
Copy link

achkasov commented May 9, 2024

Can confirm, works well under WinTerm (after using the tweak below), but not under WinTerm + Zellij.

I had to execute the following line to make the colored underline work (added it to my ~/.zshrc for convenience)

$ set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m'´

Src: helix-editor/helix#7065 (comment)

However this does not fix the colored underlines when using Zellij via WinTerm

@steakhutzeee
Copy link

steakhutzeee commented May 10, 2024

Can confirm, works well under WinTerm (after using the tweak below), but not under WinTerm + Zellij.

I had to execute the following line to make the colored underline work (added it to my ~/.zshrc for convenience)

$ set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m'´

Src: helix-editor/helix#7065 (comment)

However this does not fix the colored underlines when using Zellij via WinTerm

This should be tmux config, not zsh. Correct?

@Daydreamer-riri
Copy link

image For me, I've been acting strange on my side. Unexpected behavior occurs only in neovim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants