Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undercurl color issue #3336

Open
steakhutzeee opened this issue May 8, 2024 · 3 comments
Open

Undercurl color issue #3336

steakhutzeee opened this issue May 8, 2024 · 3 comments

Comments

@steakhutzeee
Copy link

steakhutzeee commented May 8, 2024

1. Graphical issue inside a terminal pane (eg. something does not look as it should)

Basic information

zellij --version: 0.40.1

stty size: 55 213

uname -av or ver(Windows): Linux hostname 5.15.146.1-microsoft-standard-WSL2 #1 SMP Thu Jan 11 04:09:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Issue description

Using Windows Terminal.

Inside and outside Zellij I do not see undercurls in Neovim.

Applying tmux-256color or wezterm terminfo I'm able to see the following:

Outside of Zellij:

outside_zellij

Inside of Zellij:

inside_zellij

Any idea on what is causing the colors to change inside Zellij? Tried also with default Zellij theme.

Thank you!

@trendels
Copy link

trendels commented May 16, 2024

Seeing the same thing on macOS with zellij 0.40.1 (color is slighly darker for text with curly underlines and the rest of the line after that, but only in zellij).

Edit: I was able to fix the issue for me by upgrading my terminal program.

Some more detail: I was using iterm2 with a custom .terminfo file for "xterm-256color" to enable "undercurl" support (See https://gitlab.com/gnachman/iterm2/-/issues/6382). The issue went away after switching to iterm2 beta and dropping the custom .terminfo file.

@steakhutzeee
Copy link
Author

steakhutzeee commented May 17, 2024

Interestingly after update to nvim 0.10 the undercurls are displayed correctly in Windows Terminal outside of Zellij.
In Zellij now they are displayed like regulare underlines, at least without the color issue.

@tranzystorekk
Copy link
Contributor

Here are some additional test results, done on wezterm nightly: sainnhe/gruvbox-material#205 (comment)

preferably, there would at least be a consistency that neovim under zellij displays uncolored curls as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants