Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session with only the default tab/pane does not get serialized correctly or does not serialize at all #3896

Open
deenz opened this issue Dec 27, 2024 · 0 comments

Comments

@deenz
Copy link

deenz commented Dec 27, 2024

Hello!

I am very thankful for the new resurrection feature. Unfortunately, there seems to be a bug when trying to get resurrection to work correctly when a session only has the default tab and pane. In this case, the session is either not serialized or if it is serialized, it doesn't resurrect correctly. Rather than resurrecting the session back to the shell prompt, it creates a command pane instead.

Basic information

zellij --version: 0.41.2

stty size: 66 166

uname -av or ver(Windows): Linux HX99G 5.15.167.4-microsoft-standard-WSL2 #1 SMP Tue Nov 5 00:21:55 UTC 2024 x86_64 GNU/Linux

zsh version: zsh 5.9 (x86_64-debian-linux-gnu)

Zellij config and Two tarballs attached:

zellij-log-not-serialized.tar.gz: logs created when a session was not serialized
zellij-log-serialized.tar.gz: logs created when a session was serialized, but not resurrectable as expected

zellij-log-not-serialized.tar.gz
zellij-log-serialized.tar.gz
zellij-config.tar.gz

Issue description

When a session is created, then after executing various shell commands and quitting without having added any extra tabs or panes, the session is either not serialized at all or is serialized but with a command pane rather than dropping the user to the command line.

Minimal reproduction

  1. Install zellij 0.41.2.
  2. Use attached zellij config (basically enabling resurrect, scrollback, etc).
  3. Run zellij without any args to create a default session, tab and pane.
  4. Run various commands for a minute or so.
  5. Quit
  6. View the list of sessions available for resurrection. The session may or may not have been serialized. (I expected that it would be serialized and available for resurrection).
  7. If the session was serialized, then resurrect it.
  8. A command pane is displayed requesting execution of one of the commands used during the session, rather than dropping the user to the shell. (I expected to be at the shell prompt, with with previous commands and output displayed)

Other relevant information

I recall reading something when browsing through code or discussions about a session needing additional panes or tabs beyond the default for resurrection to work for that session. However, although in many cases I use more than one tab or one pane, there are situations where I would create a session with only the default single tab and pane, and would have expected that my session would be serialized and be available for resurrection if I needed it again. So would be great if this could be fixed.

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant