Ion shell compatibility problem

[Delamare2112]

Basic information

zellij --version: 0.13.0
tput lines: 42
tput cols: 134
uname -av: Linux manjaro 5.12.9-1-MANJARO #1 SMP PREEMPT Thu Jun 3 14:56:42 UTC 2021 x86_64 GNU/Linux

alacritty --version: alacritty 0.9.0-dev (fa2fa398)
Ion Shell version: git (https://gitlab.redox-os.org/redox-os/ion) (a7c02229)

Further information

Zellij becomes frozen when doing anything that spawns a new ion shell beyond the first initial shell. Like when creating a new pane or tab for example.

I tried using different terminals and window managers until I found that the problem is Zellij + Ion Shell. If I switch my default shell to Zsh and relog, the problem goes away.

Repro:

1. use chsh to make ion your default shell
2. logout of your system, then log back into your system
3. zellij
4. echo "inside" (works fine)
5. Ctrl+p n
6. Zellij is frozen now but type (without feedback) echo "outside"
7. (in another terminal) killall -2 zellij (or some other method of closing your frozen Zellij)
8. Notice that echo "outside" and outside were both printed after Zellij closes.

[Delamare2112]

Oh yeah! The log files! Here they are:

zellij-7.log
zellij-8.log
zellij-9.log

[a-kenji]

Hey @Delamare2112.
Thank you for reaching out and filing this bug!
I can reproduce it quite easily.
I wonder what could cause this.
I'll try to look into it some more.

[a-kenji]

This problem is also apparent with nu shell.
To reproduce:

zellij options --default-shell ion
zellij options --default-shell nu

And try to start a new tab/pane.

[imsnif]

Hey @Delamare2112, thanks for reporting and debugging this. And also thanks @a-kenji as well.

This was happening because the pty thread inside Zellij did not manage to properly close these shells (ion or nu). It was sending them the SIGKILL which I guess under certain circumstances was not enough for them to die (I'm not sure which circumstances exactly - I for example only managed to reproduce this with the development build of ion and not with any build of nu).

I issued a fix for this which should be merged to main just as soon as the CI gives me a go. If you'd like to test it there to make sure, that would be great - otherwise it'll be released with the next version in the not-too-distant future.

[a-kenji]

@imsnif
Awesome, thanks for the quick fix.
It behaves well on my side now.
Yes the problem with nu was not with
every single launch.

[Delamare2112]

It works! Thanks very much for the bug fix :)