Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why preferGlobal? #345

Closed
jacobq opened this issue Dec 20, 2018 · 1 comment
Closed

Why preferGlobal? #345

jacobq opened this issue Dec 20, 2018 · 1 comment

Comments

@jacobq
Copy link

jacobq commented Dec 20, 2018

There is both a programmatic API and a command-line API. I think the preferGlobal option really only makes sense when there is nothing to require / import / use in another program. (See also this comment.)

Do we still need / want this or is it just old left-overs?

"preferGlobal": "true",

Using preferGlobal appears to be deprecated now.

@juanjoDiaz
Copy link
Collaborator

Probably legacy.

It's also wrong because it should be a boolean and not a string.

It makes sense to install globally when using json2csv as a CLI tool, and as a local dependency when using it in your code.

I'll remove it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants