Improve module manager to accept instance

[blanchonvincent]

Hi,

For the performance and to make learning easier, we can accept modules instances :

Before :

<?php
return array(
    'modules' => array(
        'Application',
        'Cron',
        'Administration',
        'Blog',
    ),
    'module_paths' => array(// my paths),
);
?>

Now, i do :

<?php
return array(
    'modules' => array(
        'Application' => new Application\Module(),
        'Cron' => new Cron\Module(),
        'Administration' => new Administration\Module(),
        'Blog' => new Blog\Module(),
    ),
);
?>

There is no BC, more natural, and perf little better.

[ralphschindler]

I like the explicitness, but how does your PHP know where these objects are located on disk? The inclusion of this particular application.ini file is before any kind of autoload munging. This would seem to imply that module/ is in your include_path and you have a special autoloader for it?

[blanchonvincent]

@ralphschindler if i use init_autoloader.php like the skeleton (with an autoloader : classmap autoloader, standard autoloader, etc.), there is no problems

[weierophinney]

Add space between statement and conditional.

[weierophinney]

As noted above, I think a few additional tests and use cases need to be considered.

[blanchonvincent]

@weierophinney I updated the PR (test with type & submodule) Do you think in other use cases ?

[Freeaqingme]

To keep this method clean (and small), perhaps you could move the contents of this if-block to their own method (e.g. loadModuleByName())?

[blanchonvincent]

Ok look cool, I updated my PR

[Freeaqingme]

I like the PR from a functional perspective. I'll let it to @weierophinney or @EvanDotPro to do the final review however.

Please note, as it primarily introduces new functionality, I think it should be merged into develop only(?).

[weierophinney]

Merged to develop for release with 2.2.0.