Added database adapter abstract service factory.

[andrei-stsiapanau]

Added database adapter abstract service factory to configure multiple database adapters for application. This abstract factory reserved db.adapters key in configuration array.

array(
            'db' => array(
                'adapters' => array(
                    'Zend\Db\Adapter\Master' => array(
                        'driver' => 'mysqli',
                    ),
                    'Zend\Db\Adapter\Slave' => array(
                        'driver' => 'mysqli',
                    ),
                ),
            ),
)

[blanchonvincent]

you should :

• no use "elseif" because you have check with "canCreateServiceWithName"
• throw exception after "elseif"

But should not return null ?

[andrei-stsiapanau]

@blanchonvincent, redundant code removed.

[blanchonvincent]

@Stephanoff ok, now you must add unit tests with the PR

[andrei-stsiapanau]

@blanchonvincent Test case added.

[ralphschindler]

This doesn't belong in the Zend\Db namespace, it really belongs in the Zend\Mvc namespace. Please see this discussion: #2903

[andrei-stsiapanau]

@ralphschindler Should I move AdapterAbstractServiceFactory to MVC namespace or my PR rejected?

[ralphschindler]

I would think we should just move the files, and keep this PR open. I'd like to also address the previous work that was done one creating a service factory for Db in the other PR.

[andrei-stsiapanau]

@ralphschindler Could you please provide FQCN for the AbstractClass since I'm new with ZF2 conventions. Thanks.

[blanchonvincent]

@ralphschindler I think it's good because :
• there is a "Zend\Db\Adapter\AdapterServiceFactory" in Zend\Db, i think the AdapterAbstractServiceFactory must to be in the same place that AdapterServiceFactory.
• there are lot of factories in her own namespaces : Zend\Navigation\Service\DefaultNavigationFactory, Zend\Cache\Service\StorageCacheFactory, etc.

[weierophinney]

@ralphschindler I've been doing a lot of thinking about whether or not these factories should be in the individual components, or in Zend\Mvc or Zend\ServiceManager.

It's not unlikely that a developer will want to use the factories outside of the MVC system. If we have the factories in Zend\Mvc, the developer then either had to add that component as a dependency, or write their own factories. This makes a great argument for having the factories in either the components or in Zend\ServiceManager. My inclination is to make them part of the components:

• The factories serve as some documentation as to how to instantiate a component and/or classes in the component, particularly in how to wire up dependencies.
• While the factories are defined by the ServiceManager component, they could potentially be consumed by another service locator and/or IoC system easily.
• Because you do not need to use the factories, the dependency on Zend\ServiceManager is an optional one. Developers would only need to add it if they choose to use the factories.

As such, I plan to merge this to the develop branch for 2.2.0.

[weierophinney]

Merged.

[chellaifajardo]

Is there a sample code snippet on how to implement this update? Thanks.

[andrei-stsiapanau]

@chellaifajardo

array(
            'db' => array(
                'adapters' => array(
                    'Zend\Db\Adapter\Master' => array(
                        'driver' => 'mysqli',
                    ),
                    'Zend\Db\Adapter\Slave' => array(
                        'driver' => 'mysqli',
                    ),
                ),
            ),

    'service_manager' => array(
        'abstract_factories' => array(
            'Zend\Db\Adapter\AdapterAbstractServiceFactory',
        ),
    ),
)

[andrei-stsiapanau]

Hi Chellai,

You are right, 'ims_db' should be adapter name, this allow access to
adapter through serviceLocator->get('ims_db'') call.

Best regards,
Andrew Stephanoff

On Thu, May 16, 2013 at 11:24 AM, Chellai Fajardo
[email protected]:

Hi Andrew,

I'm not sure if I implemented this correctly cause I'm getting an error
'could not find driver'.

I have this code on global.php

array( 'adapters' => array( 'ims_db' => array( 'driver' => 'Pdo', 'driver_options' => array( PDO::MYSQL_ATTR_INIT_COMMAND => 'SET NAMES \'UTF8\'' ), ), 'products_db' => array( 'driver' => 'Pdo', 'driver_options' => array( PDO::MYSQL_ATTR_INIT_COMMAND => 'SET NAMES \'UTF8\'' ), ), ), ), 'service_manager' => array( 'abstract_factories' => array( 'Zend\Db\Adapter\AdapterAbstractServiceFactory', ), ), ); Is it right that ims_db will be the adapter name? — Reply to this email directly or view it on GitHubhttps://github.com//pull/3933#issuecomment-17987902 .

[chellaifajardo]

Hi Andrew,

I finally made it worked. Thanks to you. 👍