Feature/zend test load module

[blanchonvincent]

The goal is to have an helper for write unit tests on module :

• for example, replace the setup of : https://github.com/blanchonvincent/SimpleMemoryShared/blob/master/tests/SimpleMemoryShared/MemorySharedManagerTest.php
• can load specific config like on this issue : Zend\Test service manager bootstrapper #3845

[blanchonvincent]

@Ocramius can read this PR ? thank you :)

[Ocramius]

Why abstract? And why extending a PHPUnit_Framework_TestCase?

[blanchonvincent]

Look my unit test, the goal was provide a "loadModule" method with direct assertion without usage of "new"

[Ocramius]

@blanchonvincent perfectly clear what the intent was, I think that isn't an optimal approach (especially since it's an util, not a test case).

[blanchonvincent]

@Ocramius agree with you, it was just a draft :) i will change that

[Ocramius]

@blanchonvincent the idea looks good so far, BUT there's way too much public API in my opinion.

You should probably have something like:

• __construct($modules, $modulePaths) (or $applicationConfig)
• getServiceManager()
• getModuleManager()
• getApplication()

No other public API is needed in my opinion (that's already probably too much) :)

Usage would be:

class MyTest extends PHPUnit_Framework_TestCase
{
    public function testFoo()
    {
        $moduleLoader = new \Zend\Test\PHPUnit\Util\ModuleLoader(array(
            'modules' => array('Application')
        ));

        $this->assertInstanceOf(
            'Zend\ServiceManager\ServiceLocatorInterface',
            $moduleLoader->getServiceManager()
        );
        $this->assertInstanceOf(
            'Zend\ModuleManager\ModuleManager',
            $moduleLoader->getModuleManager()
        );
        $this->assertInstanceOf(
            'Zend\Mvc\ApplicationInterface',
            $moduleLoader->getApplication()
        );
    }
}

[blanchonvincent]

@Ocramius I did not know if I had to make a external class (like you) or internal class with PHPUnit_Framework_TestCase integrated (like me).
Your solution look more natural and easy to understand for new user.

[Ocramius]

@blanchonvincent it's not really about ease of use... I'm mainly thinking of something that doesn't enforce inheritance from another test case (we got so many already :( )

[blanchonvincent]

@Ocramius yeah, you are right

[Ocramius]

@blanchonvincent ping again once you think you've sorted it out, and thank you for picking this =)

[blanchonvincent]

@Ocramius second draft, look better, i will add unit tests again later

[Ocramius]

As before: if a module is provided as name => path, then the module manager should already be able to handle that :)

[blanchonvincent]

@Ocramius if you write in your config :

'modules' => array(
    'Foo' => '/path/to/my/foo',
),

?

Currently in "modules" key, only name is accepted : https://github.com/zendframework/zf2/blob/master/library/Zend/ModuleManager/ModuleManager.php#L80

[Ocramius]

@EvanDotPro ping?

[Ocramius]

Looks much better, thank you! :)

[weierophinney]

@blanchonvincent I tried merging, but I'm missing the file tests/ZendTest/Test/_files/cache/module-config-cache.phpunit.php (notified in ModuleLoaderTest::testCanLoadModulesFromConfig).

[blanchonvincent]

@weierophinney you must only create the "cache" directory in "tests/ZendTest/Test/_files/". I add the directory in the versioning.

[weierophinney]

@blanchonvincent Do not write files inside the tests directory; write them to the system temporary directory. (We need to do this in part to allow developers to run the test suite when installed via their system package manager; if we write inside the tests directory, they may not have permissions. Plus, it's cleaner.)

[blanchonvincent]

@weierophinney sorry, i changed with the system temporary directory.

[weierophinney]

@blanchonvincent I ran into issues running the test suite multiple times, as the test suite is not cleaning out the cache files. Interestingly, when I implemented that logic... a new test started failing consistently, AbstractControllerTestCaseTest::testApplicationClassAndTestRestoredConsoleFlag now fails on the very first assertion of Console::isConsole. Trying to track it down...

[weierophinney]

Tracked it down, and all tests are running. Thanks, @blanchonvincent -- merged to develop for release with 2.2.0.

[Ocramius]

👍!

[blanchonvincent]

@weierophinney @Ocramius Thank you both for your work