Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Hydrator aware interface #4016

Closed
wants to merge 370 commits into from
Closed

Hydrator aware interface #4016

wants to merge 370 commits into from

Conversation

ghunti
Copy link
Contributor

@ghunti ghunti commented Mar 13, 2013

Hi.

I've created a HydratorAwareInterface, that mimics the behaviour of the InputFilterAwareInterface.

This way we can avoid setting the hydrator on the form every time, we just make the object that we bind to the form aware of its own hydrator (with a simple getter and setter).

The patch uses the object hydrator if the form doesn't have one hydrator already, and this might be one of the points were you for sure have a better understanding if this is correct or not.

Thanks,

weierophinney and others added 30 commits March 1, 2013 09:35
configuration.

Change-Id: Ibd9309bf42c8992376849a1c5bbae05cd82e4c13
Change-Id: I568ec78485724be3ec68c0b754d9af95b3ea1b03
Change-Id: I071cf7b8e41d3f7f06f942650dc6f8a3d2215cba
method.

Change-Id: I4a3bb387e4f63c5aa70519923ad3680c8ae5e5b0
method.

Change-Id: Idf4802f8735a2333d927f5c6989e124c048e7854
Change-Id: I382bc52191f3202b47ecd7910a2ffb4108c7e78e
Change-Id: Ib47b1604675e5beef8945b57df9dfb28ddef3ffd
Change-Id: Ifb6241ff0d3799dbefdd9bd160e7f14c3ab68bf8
Change-Id: Ibd0e492df076b801cb91078753bfe40bf77f63c0
Change-Id: Ia85eab01106afa54e8156dadb9fece15d73e9ae8
Minor improvements in abstract factory methods.

Change-Id: Ic6d1de0efede8780ff6d50126b98b50dee5fa5fb
Change-Id: Ib79a1e12bf93f53f44765ac2add526c3ccecfa6f
Change-Id: I32e556441e7ba46367b1a1a7485ab00e0cdcd6df
Change-Id: I93522febd9f4c61286a2bce36bf3a1333a54e1ae
weierophinney and others added 23 commits March 28, 2013 11:39
- linefeed
fix (bool) casting : add space and use (bool) instead of (boolean) to cast
Forward port #4117

Conflicts:
	tests/ZendTest/InputFilter/FactoryTest.php
Allow to change option creations for plugin manager
Allow to change option creations for plugin manager
Merge branch 'Mech7-fix-db-resource' into develop
@ghunti
Copy link
Contributor Author

ghunti commented Apr 1, 2013

@weierophinney It seems that i've made something on my local branch that broken this all up.
What should i do? Open a new pull request? Anyway, I've added the unit tests for the new Interface on commit https://github.com/ghunti/zf2/commit/b576cde361ef4933916eacd89dac4bd0169299df.

Sorry for all the mess

@ghunti
Copy link
Contributor Author

ghunti commented Apr 1, 2013

@mpalourdio I'm not an expert, not i know very well how forms operate on the backend. I've just tried to mimic the InputFIlterAwareInterface without breaking current hydrator + form behavior.

Can you help me with an example?
Thanks

@ghost
Copy link

ghost commented Apr 2, 2013

I don't have an precise example to provide you, and i don't even know if it's really possible. But imagine you have a form that is populated with 2 fieldsets. One fieldset is hydrated with the standard zf2 hydrator, and the other is hydrated by the doctrine hydrator from a doctrine entity. I was just wonderind if your interface could merge the 2 fieldsets each populated with a distinct hydrator. Maybe @weierophinney could best guide you with this particular case.

@macnibblet
Copy link
Contributor

@ghunti When working on new features you must work in a new branch, else when you create a PR and update your master/develop it get filled with other peoples commits. So create a new branch and cherry-pick the commits you need and create a new pull request.

@ghunti ghunti mentioned this pull request Apr 2, 2013
@ghunti
Copy link
Contributor Author

ghunti commented Apr 2, 2013

Created a new pull request with the relevant commits on #4170

@ghunti ghunti closed this Apr 2, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.