Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Moved ext-intl to suggest instead of require to avoid silent fallback. #4048

Merged
merged 1 commit into from
Mar 27, 2013
Merged

Moved ext-intl to suggest instead of require to avoid silent fallback. #4048

merged 1 commit into from
Mar 27, 2013

Conversation

spiffyjr
Copy link
Contributor

No description provided.

@weierophinney
Copy link
Member

What's the "silent fallback," exactly?

@spiffyjr
Copy link
Contributor Author

If you don't have the intl extension installed composer will notice a failure and fallback to the primary zf2 repository silently. Moving ext-intl to suggests accomplishes two things:

  1. The user will receive a suggestion to install i18n (avoiding a fatal_error with no info with the fallback).
  2. The "silent fallback" will be avoided.

weierophinney added a commit that referenced this pull request Mar 27, 2013
Moved ext-intl to suggest instead of require to avoid silent fallback.

Conflicts:
	library/Zend/I18n/composer.json
weierophinney added a commit that referenced this pull request Mar 27, 2013
@weierophinney weierophinney merged commit 5c5d650 into zendframework:develop Mar 27, 2013
@ghost ghost assigned weierophinney Mar 27, 2013
@spiffyjr spiffyjr deleted the hotfix/i18n-composer branch March 28, 2013 03:06
weierophinney added a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
…fix/i18n-composer

Moved ext-intl to suggest instead of require to avoid silent fallback.

Conflicts:
	library/Zend/I18n/composer.json
weierophinney added a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants