This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Service manager performance optimized #4139
Merged
weierophinney
merged 6 commits into
zendframework:develop
from
Ocramius:feature/service-manager-performance-optimized
Apr 11, 2013
Merged
Service manager performance optimized #4139
weierophinney
merged 6 commits into
zendframework:develop
from
Ocramius:feature/service-manager-performance-optimized
Apr 11, 2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea whatsoever why the build fails. Ok, @weierophinney found out it's an un-related problem with RandomLib going out of memory. For comparison, here's the results over 100000 iterations:
|
I see that also var_dump'd in the test... you may consider removing it :)
|
@mwillbanks yes, these performance tests are here for the only purpose of showing that it works. I noted that in the PR description |
ghost
assigned weierophinney
Apr 11, 2013
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2013
…mance-optimized Service manager performance optimized
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2013
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…ture/service-manager-performance-optimized Service manager performance optimized
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inlines some of the methods internal to the service manager. Following changes may be potential BC breaks:
canCreate
has been deprecated (as it seems, it is an internal method anyway. Users should keep usinghas
)isSubclassOf
has been deprecated (was used internally)canonicalizeName
each timeNOTE: if this one is ok, remove the performance test case before merging (or tell me to do so)