This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Make identifier name configurable for AbstractRestfulController #4181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
AbstractRestfulController::getIdentifier()
hard codes a lookup on anid
parameter in either the route matches or the query string. This is not optimal in the case of child resources, as it forces the creation of additional routes to ensure that the:id
segment is specific to the given child resource:versus the more semantic:
This PR makes the identifier name configurable. BC is retained, as it still defaults to "id"; however, new methods allow you to inject an alternate identifier name, and that name will be used by
getIdentifier()
in order to look up the resource ID.