This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Remove superfluous indentation from one line of code #4263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line is indented by one too many levels. It's been indented relative to the part of the if statement that's been broken onto a second line, rather than relative to the previous indentation level itself. This makes it look like two nested if statements instead of the one that's actually there.
|
good to merge. |
weierophinney
added a commit
that referenced
this pull request
Apr 22, 2013
Remove superfluous indentation from one line of code
weierophinney
added a commit
that referenced
this pull request
Apr 22, 2013
- CS indicates && and || should be on next line; multiline conditionals should put the closing paren and brace on a line of their own.
ghost
assigned
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…ionfix Remove superfluous indentation from one line of code
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
- CS indicates && and || should be on next line; multiline conditionals should put the closing paren and brace on a line of their own.
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line is indented by one too many levels. It's been indented relative to the
part of the if statement that's been broken onto a second line, rather than
relative to the previous indentation level itself. This makes it look like two
nested if statements instead of the one that's actually there.