This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix for a problem with Service Manager and Abstract Factories #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 21, 2013 02:53
| * @link http://github.com/zendframework/zf2 for the canonical source repository | ||
| * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com) | ||
| * @license http://framework.zend.com/license/new-bsd New BSD License | ||
| * @package Zend_ServiceManager |
added 2 commits
April 21, 2013 20:55
weierophinney
added a commit
that referenced
this pull request
Apr 22, 2013
Fix for a problem with Service Manager and Abstract Factories
ghost
assigned 
|
In unut tests, for get one service once, TrollAbstractFactory::canCreateServiceWithName menthod will be called 6 times |
|
@turrsis that's way too few information to start debugging the problem |
|
@Ocramius I'll examine this question now |
|
this is still reproducible. I've added the test in #5390. |
stefanotorresi
pushed a commit
to stefanotorresi/zf2
that referenced
this pull request
Oct 31, 2013
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…endServiceManager Fix for a problem with Service Manager and Abstract Factories
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a abstract factory, inside the method
canCreateServiceWithName(), try to check or retrieve a service that doesn't exists, a loop is created between the service manager and the given factory - see the test to get a better idea.I'm not sure if my fix is a good one, but that's everything I can do. If someone else have a better approach to solve this, please feel free to fix it. :)
My idea was to skip the abstract factory when it, coupled with the canonical name, was the last one to be used.