This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Suggestion: Don't render empty module console information #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will allow modules to provide the console usage and banner information dynamically and returning an empty array/string when nothing should be rendered. A module can now check the environment and capabilities before returning the information.
This change will allow modules to provide the console banner information dynamically and returning an empty string when nothing should be rendered. A module can now check the environment and capabilities before returning the information. This was missing in the last commit
weierophinney
added a commit
that referenced
this pull request
Apr 23, 2013
Suggestion: Don't render empty module console information
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow modules to provide the console usage and banner
information dynamically and returning an empty array/string when nothing
should be rendered.
A module can now check the environment and capabilities before returning
the information.