This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Method annotations of Zend\Validator\Hostname constructor #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The annotations may not be out of sync, as the constructor is overloaded and can be called with the indicated parameters. |
|
agree with @micheh |
|
Then at least the names of the parameters should reflect the keys of the options array to make it more obvious what the parameters are intended for. Updating the PR in a minute. |
- Revert changes applied with 3389ae3 - Update names of parameters to reflect keys used in option array - Use int instead of integer for type
| * @param int $allow OPTIONAL Set what types of hostname to allow (default ALLOW_DNS) | ||
| * @param bool $useIdnCheck OPTIONAL Set whether IDN domains are validated (default true) | ||
| * @param bool $useTldCheck Set whether the TLD element of a hostname is validated (default true) | ||
| * @param Ip $ipValidator OPTIONAL |
There was a problem hiding this comment.
Fixed the alignment of annotations along the way.
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Apr 29, 2013
Method annotations of Zend\Validator\Hostname constructor Conflicts: library/Zend/Validator/Hostname.php
weierophinney
added a commit
that referenced
this pull request
Apr 29, 2013
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…otfix/method-annotations Method annotations of Zend\Validator\Hostname constructor Conflicts: library/Zend/Validator/Hostname.php
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method annotations of
Zend\Validator\Hostnameconstructor are out of sync.