This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Glob::glob() should throw an exception on error #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ErrorHandler::start(); | ||
| $res = glob($pattern, $globFlags); | ||
| $err = ErrorHandler::stop(); | ||
| if ($res === false) { |
There was a problem hiding this comment.
False may actually not directly be an error. Best is to just return an array() on false if no error is thrown. Just throw an exception if there was actually an error.
There was a problem hiding this comment.
glob returns false in cases of an error only. empty results, unreadable folders by permission ... are resulting in an empty array. tested with PHP-5.3.10 on Ubuntu12.
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Apr 29, 2013
Glob::glob() should throw an exception on error Conflicts: library/Zend/Stdlib/Glob.php
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…tfix/3949 Glob::glob() should throw an exception on error Conflicts: library/Zend/Stdlib/Glob.php
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #3949.
It also makes the second argument
$flagsoptional.Please note: This could be a BC break as
Glob::glob()no longer returnsfalseon error and instead throws aZend\Stdlib\Exception\RuntimeExceptionbut the ZF2 doesn't check againstfalse.