This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Use InputFilterPluginManager in InputFilter\Factory #4365
Merged
weierophinney
merged 5 commits into
zendframework:develop
from
danizord:hotfix/inputfilter-factory-use-plugin-manager
May 1, 2013
Merged
Use InputFilterPluginManager in InputFilter\Factory #4365
weierophinney
merged 5 commits into
zendframework:develop
from
danizord:hotfix/inputfilter-factory-use-plugin-manager
May 1, 2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And rename $element to $inputFilter
$factory->setFormElementManager($this); | ||
|
||
if ($this->serviceLocator instanceof ServiceLocatorInterface) { | ||
$inputFilters = $this->serviceLocator->get('InputFilterManager'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to check with has()
before pulling this; right now, form tests fail due to that. (I'll probably fix this on merge, though.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
weierophinney
added a commit
that referenced
this pull request
May 1, 2013
…-plugin-manager Use InputFilterPluginManager in InputFilter\Factory
weierophinney
added a commit
that referenced
this pull request
May 1, 2013
- Check if the composed service locator has the InputFilterManager prior to attempting to retrieve it.
weierophinney
added a commit
that referenced
this pull request
May 1, 2013
ghost
assigned weierophinney
May 1, 2013
fimbulvetr
pushed a commit
to fimbulvetr/zf2
that referenced
this pull request
Nov 20, 2013
…er via arguments, it called setInputFilterManager. setInputFilterManager assumed default filter/validator chains were initialized if serviceLocator was present, which is not the case, as defaultFilter/Validator are not set until later in the constructor.
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
…fix/inputfilter-factory-use-plugin-manager Use InputFilterPluginManager in InputFilter\Factory
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to send it at the last minute, but I think it is relevant to be released with 2.2. 😃