Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Use InputFilterPluginManager in InputFilter\Factory #4365

Conversation

danizord
Copy link
Contributor

@danizord danizord commented May 1, 2013

Sorry to send it at the last minute, but I think it is relevant to be released with 2.2. 😃

$factory->setFormElementManager($this);

if ($this->serviceLocator instanceof ServiceLocatorInterface) {
$inputFilters = $this->serviceLocator->get('InputFilterManager');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check with has() before pulling this; right now, form tests fail due to that. (I'll probably fix this on merge, though.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

weierophinney added a commit that referenced this pull request May 1, 2013
…-plugin-manager

Use InputFilterPluginManager in InputFilter\Factory
weierophinney added a commit that referenced this pull request May 1, 2013
- Check if the composed service locator has the InputFilterManager prior
  to attempting to retrieve it.
weierophinney added a commit that referenced this pull request May 1, 2013
@weierophinney weierophinney merged commit f27d372 into zendframework:develop May 1, 2013
@ghost ghost assigned weierophinney May 1, 2013
fimbulvetr pushed a commit to fimbulvetr/zf2 that referenced this pull request Nov 20, 2013
…er via arguments, it called setInputFilterManager. setInputFilterManager assumed default filter/validator chains were initialized if serviceLocator was present, which is not the case, as defaultFilter/Validator are not set until later in the constructor.
weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
…fix/inputfilter-factory-use-plugin-manager

Use InputFilterPluginManager in InputFilter\Factory
weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants