This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Decouple I18n\View\Helper\AbstractTranslatorHelper from ext\intl #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| { | ||
| parent::__construct(); | ||
|
|
||
| $this->timeType = IntlDateFormatter::LONG; |
There was a problem hiding this comment.
You are missing the exception in this area.
There was a problem hiding this comment.
@mwillbanks It's thrown by the parent constructor.
|
Please also supply unit tests to verify the behavior. |
|
@mwillbanks there is no test written for other extension checking like and many others. Btw, I'll be happy to create tests if anyone can make a Travis build without |
| @@ -12,6 +12,7 @@ | |||
| use Locale; | |||
| use IntlDateFormatter; | |||
| use Traversable; | |||
| use Zend\I18n\Exception as I18nException; | |||
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
May 2, 2013
Decouple I18n\View\Helper\AbstractTranslatorHelper from ext\intl
weierophinney
added a commit
that referenced
this pull request
May 2, 2013
- s/Extensions/Extension/g - Added explanatory comments - Alias both exception types in DateTime validator
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
…fix/intl-optional Decouple I18n\View\Helper\AbstractTranslatorHelper from ext\intl
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
- s/Extensions/Extension/g - Added explanatory comments - Alias both exception types in DateTime validator
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/zendframework/zf2/blob/release-2.2.0rc1/library/Zend/I18n/View/Helper/AbstractTranslatorHelper.php#L34-L45
is too wide and involves also
https://github.com/zendframework/zf2/blob/release-2.2.0rc1/library/Zend/Form/View/Helper/AbstractHelper.php#L13
which has nothing to do with
ext\intlapart forFormMonthSelectand its descendantsWithout this fix, no
Form\View\Helpercan be used ifext\intlis missing.I had to put some attribute initialization into constructors to avoid unmanagable fatal errors.