This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fix docblocks : "Zend_" should be "Zend\" and some typos #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not edit some of Zend\View docblocks yet because it will conflict with #3935 |
| @@ -23,7 +23,7 @@ public function handle(array $httpData = null, $sendResponseNow = false); | |||
|
|
|||
| /** | |||
| * Send the response, including all headers. | |||
| * If you wish to handle this via Zend_Controller, use the getter methods | |||
| * If you wish to handle this via Controller, use the getter methods | |||
There was a problem hiding this comment.
Should be Zend\Mvc\Controller
|
I started commenting... but realized there's one big comment: Basically, it looks like you did primarily a search/replace, and the problem is that many of the class names have changed -- they might be further down in the hierarchy (Zend_Mime vs Zend\Mime\Mime), they may reference new interfaces ( Shall I mark it as a WIP? |
|
@weierophinney updated. let me know if any correction. |
|
@weierophinney in Zend\Mime\Mime i found Zend_Mime::LINEEND and LINEEND used together. what should it be ? Zend\Mime\Mime::LINEEND or changed all to just LINEEND ? |
|
I prefer Zend\Mime\Mime::LINEEND |
|
after i see other files, Zend\Mime\Mime::LINEEND only if linked by other class ;) |
|
@weierophinney I've updated. I don't know why travis still show error. |
|
@samsonasik Can you rebase off of current master, please? As it stands now, there are merge conflicts. Thanks! |
|
@weierophinney ok, done, rebased. |
weierophinney
added a commit
that referenced
this pull request
May 23, 2013
fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
that referenced
this pull request
May 23, 2013
- Since class name listed in exception changed, expected exception message needed to change
ghost
assigned
|
@samsonasik The travis failures were due to the change in an exception string in XmlRpc -- two tests needed to be updated to replace "_" with "". :) |
|
@weierophinney Thank You. |
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-barcode
that referenced
this pull request
May 14, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-barcode
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-barcode
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-captcha
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-dom
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-dom
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-dom
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-permissions-acl
that referenced
this pull request
May 15, 2015
…ix/docblock.Zend_ fix docblocks : "Zend_" should be "Zend\" and some typos
weierophinney
added a commit
to zendframework/zend-permissions-acl
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-permissions-acl
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in library\Zend