Minor param overflow #4423
Minor param overflow #4423
Conversation
Needs to be Interface typecase
setExpirationHops method was changed and now only takes 2 params. Three where still provided in various locations.
| @@ -24,7 +24,7 @@ class Sql | |||
| /** @var Platform\Platform */ | |||
| protected $sqlPlatform = null; | |||
|
|
|||
| public function __construct(AdapterInterface $adapter, $table = null, Platform\AbstractPlatform $sqlPlatform = null) | |||
| public function __construct(AdapterInterface $adapter, $table = null, PlatformInterface $sqlPlatform = null) | |||
There was a problem hiding this comment.
this should be a seperate PR
There was a problem hiding this comment.
Sorry new to this not sure how yet...
There was a problem hiding this comment.
Just revert this change, push to your remote, and this PR is updated.
For your change, please create a fresh branch and push it to your remote again.
This reverts commit 8ebd5ed.
ghost
mentioned this pull request
|
Better now I hope? |
|
PR 4429 and PR 4423 are identical? |
|
I reverted the mistaken PR |
|
Well, perhabs my english is not good enough, I try to explain again: One branch contains the setExpirationHops fix, the other one will care about the typehint in Sql. Currently you have two PR's both taking care of setExpirationHops. |
Minor param overflow
Minor param overflow
SessionContainer::setExpirationHops
only takes 2 params, 3 still provided in various locations.
More a beauty thing perhaps.