Fix FormElementManagerFactory breaks csrf validation (in Mvc)

[noopable]

No description provided.

[noopable]

Please tell me why The Travis build faild anyone else ?
https://travis-ci.org/zendframework/zf2/builds/6908578
This says it is green at 5.3, 5.4 , red at 5.3.3.

[weierophinney]

Looks like it's likely a segfault; I'll look into it tomorrow morning.
On May 5, 2013 7:45 PM, "Tomoaki Kosugi" [email protected] wrote:

Please tell me why The Travis build faild anyone else ?
https://travis-ci.org/zendframework/zf2/builds/6908578
This says it is green at 5.3, 5.4 , red at 5.3.3.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4425#issuecomment-17462565
.

[noopable]

Now good. Perhaps there were some bad lines about null conversion.

[weierophinney]

The DiMock implementation looks hacky, and makes for some tight coupling with DI. I'm not certain I like this.

I'm going to play with this to see if there's another approach we can use.

[weierophinney]

@noopable Your tests have nothing to do with DI, which makes this even more... hacky... to me. I'm going to try merging just the tests and changes to Zend\Form for now.

[weierophinney]

@noopable Merging just the changes to form, the tests all pass, in both 5.3.3 and other versions. I'm going to merge just those; if you can work up a test for the DI-related stuff later, I'll consider it, though, as noted, I have concerns about having DI-specific form sniffing.

[noopable]

@weierophinney
I don't like The DiMock implementation too.
I suppose that it would better to remove ”Aware”. Or the di component would better give up auto binding if the object was not found . The point at issue is to instantiate an "interface".