[WIP] Di compatibility (#4434)

[noopable]

Relative to #4434
Now we cannot get some instances from the di even if the zf2's simple classes. This PR is a hotfix for it.
And this also enhances the capability to manage dependencies explicitly. But it has a minor BC break. If we should keep BC strictly, remove a5f1362 , b0d918e

Overview

METHOD_IS_REQUIRED:

Resolve dependencies
by specified params and TypePreference and name as Class.
Missing parameter and raise exception

• constructor
• instantiator
• set method option METHOD_IS_REQUIRED or (required => true) explicitly

METHOD_IS_EAGER:

Resolve dependencies
by specified params and TypePreference and name as Class.
Missing parameter and give up resolving

• AwareInterface's setter
• set method option METHOD_IS_EAGER explicitly

METHOD_IS_OPTIONAL:

Resolve dependencies only by specified params

• setter injection

---

• Add issue reproduce test
• Initial implementation
• Collect feedback
• Test coverage

[samsonasik]

remove @Package

[weierophinney]

@noopable I've marked this a "work in progress" as it's clear you've written tests, but are still working on solutions.

[noopable]

Thanks. I'll be counting on you.

[weierophinney]

@noopable Oh, I thought you were doing the work. :)

[noopable]

@weierophinney
Oops!　I'm sorry.I didn't understand which .
I’ll give it a try.

[noopable]

I wrote the first implementation.
Please give me feedback on this.

[weierophinney]

@noopable Looks great! If you're ready to sign off on it -- i.e., it solves the issues you were seeing with forms -- I can get this into 2.2.0RC3.

[noopable]

@weierophinney
Thanks.
If the current state was ok, I want to release it now. And I will make tests in another PR.
If it is accepted, we can revert the commits ( 69dc3de 9afbe6f ) and some issues may be .

[weierophinney]

@noopable Interestingly, I cannot revert either of those two commits, as doing so introduces new failures and/or errors.

If I revert 9afbe6f, I get new failures in the FormElementManagerFactory tests, in the testCsrfCompatibility and testCsrfWorkflow methods; essentially, I do not receive the expected hashes.

If I revert 69dc3de, I get errors in the same test suite, in the testWillInstantiateFormFromDiAbstractFactory, testNoWrapFieldName, and same CSRF tests as above. In each case, I get the exception "An abstract factory could not create an instance..."

Can you try reverting these on your branch and figuring out what changes need to be made to make them pass?

[noopable]

I'm sorry.
something is wrong about me.

[weierophinney]

@noopable revert & new commit is good -- it's explicit.

BTW, just pulled, and seeing 3 new failures on DiTest: testNewInstanceThrowsExceptionOnBasicCircularDependency, testNewInstanceThrowsExceptionOnThreeLevelCircularDependency, and testNewInstanceThrowsExceptionWhenEnteringInMiddleOfCircularDependency -- each with the message "Missing instance/object for parameter ...". My guess is it's related to 4b3ed42.

[weierophinney]

@noopable I have a working solution:

diff --git a/library/Zend/Di/Di.php b/library/Zend/Di/Di.php
index f70a457..a1fc612 100644
--- a/library/Zend/Di/Di.php
+++ b/library/Zend/Di/Di.php
@@ -12,6 +12,7 @@ namespace Zend\Di;
 use Closure;
 use ReflectionClass;
 use Zend\Di\Exception;
+use Zend\ServiceManager\Exception\ExceptionInterface as ServiceManagerException;

 /**
  * Dependency injector that can generate instances using class definitions and configured instance parameters
@@ -757,9 +758,25 @@ class Di implements DependencyInjectionInterface
                     } else {
                         $resolvedParams[$index] = $this->get($computedParams['retrieval'][$fqParamPos][0], $callTimeUserParams);
                     }
-                } catch (\Exception $e) {
+                } catch (Exception\RuntimeException $e) {
+                    if ($methodRequirementType & self::RESOLVE_STRICT) {
+                        //finally ( be aware to do at the end of flow)
+                        array_pop($this->currentDependencies);
+                        // if this item was marked strict,
+                        // plus it cannot be resolve, and no value exist, bail out
+                        throw new Exception\MissingPropertyException(sprintf(
+                            'Missing %s for parameter ' . $name . ' for ' . $class . '::' . $method,
+                            (($value[0] === null) ? 'value' : 'instance/object' )
+                        ),
+                        $e->getCode(),
+                        $e);
+                    } else {
+                        //finally ( be aware to do at the end of flow)
+                        array_pop($this->currentDependencies);
+                        return false;
+                    }
+                } catch (ServiceManagerException $e) {
                     //Zend\ServiceManager\Exception\ServiceNotCreatedException
-                    //Zend\Di\Exception\RuntimeException
                     if ($methodRequirementType & self::RESOLVE_STRICT) {
                         //finally ( be aware to do at the end of flow)
                         array_pop($this->currentDependencies);

[weierophinney]

@noopable The solution posted above works, and does not present a hard dependency on ServiceManager.

[weierophinney]

@noopable Looks good! Preparing to merge now!

[noopable]

@weierophinney
Thank you very much.
I'm sorry about bad commits.

[weierophinney]

@noopable No worries -- great work!

[noopable]

Thank you!