Zend\Authentication\Result custom result codes not possible

[weierophinney]

What's the point of this in the Result constructor:

    if ($code < self::FAILURE_UNCATEGORIZED) {
        $code = self::FAILURE;
    } elseif ($code > self::SUCCESS ) {
        $code = 1;
    }

It pretty much nullifies the usefulness of any classes that extend result using custom codes without making a custom constructor, and seems to be there for no discernible reason.

[weierophinney]

Actually... this change would only make sense if we were using static:: instead of self:: for resolution -- and even then, the fact is that AuthenticationService is checking for the specific Result constants, which means self:: is correct.

Can you clarify what you feel needs to change, please, @JustinBuser ?

[mwillbanks]

This portion of the code actually drives me insane also; I extend it by using the constructor right now.

I have several different codes that I use today and throw differently in the constructor. This kills the open/close principle in a bad way :(

[JustinBuser]

Remove it, it serves no purpose other than to override values that are being explicitly set, ergo: shouldn't need to be overwritten. Can you cite some reason it needs to be there?

[weierophinney]

@mwillbanks Okay, updated -- tests still pass, so should be fine. Please review! :)

[JustinBuser]

Perfection, 👍