This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add ConstantScanner to Zend\Code\Scanner #4465
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* | ||
* @return ConstantScanner[] | ||
*/ | ||
public function getConstants() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a BC break, and we can't do that.
I'd argue instead for the following:
- have an optional flag argument to
getConstants()
,$namesOnly
, that defaults to true. - When
$namesOnly
is true, it will proxy togetConstantNames()
. Additionally, raise anE_USER_DEPRECATED
error, so that developers know they should alter their code to usegetConstantNames()
if they want the original behavior. - when the flag is false, do the new behavior.
This will allow developers to opt-in to the new behavior, and give us a migration path.
ghost
assigned weierophinney
May 23, 2013
@weierophinney Addition of |
@MatyCZ alter the tests to check for the error as well as the behavior. |
weierophinney
added a commit
that referenced
this pull request
Jun 11, 2013
Add ConstantScanner to Zend\Code\Scanner
weierophinney
added a commit
that referenced
this pull request
Jun 11, 2013
- Add error handler, and verify E_USER_DEPRECATED was raised - Ensure name of constant is correct case
ghost
assigned weierophinney
Jun 11, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug introduced in #4457 and add some new features.
There is one BC break. Method getConstants() don't return constant names now, but return instance of ConstantScanner.