Incompatible with RecursiveIterator::hasChildren() Zend\Navigation\AbstractContainer

[noopable]

Zend\Navigation\AbstractContainer implements RecursiveIterator.
But Zend\Navigation\AbstractContainer::hasChildren is incompatible with RecursiveIterator::hasChildren().

RecursiveIterator::hasChildren() is that
Returns if an iterator can be created for the current entry.
// (at)see http://php.net/manual/en/recursiveiterator.haschildren.php

Not that returns if the iterator has entries.

For example, RecursiveArrayIterator::hasChildren returns whether current entry is an array or an object.

It should be

    public function hasChildren()
    {
        return $this->current()->hasPages();
    }

Otherwise, it causes some problems with using RecursiveIteratorIterator::beginChildren and so on.

[froschdesign]

@noopable
Can you provide an unit test? Thanks.

[noopable]

I made it.
Thank you.

[Ocramius]

Handled in #6825

[Moring]

@Ocramius suggested that I ask here: to me, feel free to have other opinions, hasChildren() seems to have different than expected behavior of an RecursiveIterator implementation. Perhaps we call this out in the documentation somewhere?

[noopable]

but does this seem to be different than expected behavior of an RecursiveIterator implementation

Indeed, the name ,RecursiveIterator::hasChildren(), sounds like if RecursiveIterator has children or not.
But the fact is that, it is , so to speak, RecursiveIterator::currentHasChildren(). And so, RecursiveIterator::getChildrenFromCurrent(). -- These name are so strange.

In the PHP Manual,
http://php.net/manual/en/recursiveiterator.haschildren.php
It returns if an iterator can be created for the current entry.

And this relatives to getChildren
http://php.net/manual/en/recursiveiterator.getchildren.php
It returns an iterator for the current iterator entry.

The ordinary recursive flow is below.

1. check the current to have children or not. (hasChildren())
2. If true, get the children of the current. (getChildren())

You can see and compare this pattern in the RecursiveArrayIterator or the RecursiveDirectoryIterator and so on.
Or other classes that implements \RecursiveIterator.
https://github.com/zendframework/zf2/blob/master/library/Zend/Mail/Storage/Folder.php#L61
https://github.com/zendframework/zf2/blob/master/library/Zend/Permissions/Rbac/AbstractIterator.php#L87

Thanks.

[sven-tappert]

However, this should have been marked as Breaking Change in the Release notes! Checking for subpages with hasChildren() will now fail in navigation partials. One has to use hasPages() instead.