This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix for unmatched routes in navigation #4530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a unit test, so we don't have another regression in the future. |
|
@weierophinney I have added a test, but am not sure if the route match object is required? Maybe it goes somewhere else wrong if an error event is triggered? The extra check in the if statement seems to work for me, but not sure what else can go wrong here :) |
|
@mech7 test looks good! The big question: does it fail prior to the fix? And it does. :) Merging! |
weierophinney
added a commit
that referenced
this pull request
May 23, 2013
Fix for unmatched routes in navigation
ghost
assigned
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…-nav-fix Fix for unmatched routes in navigation
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zf 2.2 changed the navigation behaviour for the segment route from 2.1.5 it needs the route match to keep the old behavior only on error (404) pages the route is not matched and will throw and error on the getParams method as it is not an object.