Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Possibility to use camelCase for all soap client options #4605

Closed
wants to merge 1 commit into from
Closed

Possibility to use camelCase for all soap client options #4605

wants to merge 1 commit into from

Conversation

neeckeloo
Copy link
Contributor

No description provided.

@ralphschindler
Copy link
Member

Is this just a personal preference thing? Our standards say moving forward, all options should be under_score.

@weierophinney
Copy link
Member

@ralphschindler Actually, this just makes it consistent with the other options in the soap client -- we already have things like the following:

case 'classmap':
case 'class_map':
    // do some stuff
    break;

This is done to allow either underscore separated, all lower case, all upper case, or camelcased.

We apparently missed it with some of the ones added later.

@neeckeloo
Copy link
Contributor Author

Personaly, I usually use underscore but it's only purpose of code consistency as @weierophinney says.

@ghost ghost assigned weierophinney Jun 11, 2013
weierophinney added a commit that referenced this pull request Jun 11, 2013
Possibility to use camelCase for all soap client options
weierophinney added a commit that referenced this pull request Jun 11, 2013
weierophinney added a commit to zendframework/zend-soap that referenced this pull request May 15, 2015
…ap-client-options

Possibility to use camelCase for all soap client options
weierophinney added a commit to zendframework/zend-soap that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-soap that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants