This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow selecting the TranslatorAwareTreeRouteStack via configuration #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows usage of TranslatorAwareTreeRouteStack via configuration now:
'router' => array(
'route_class' => 'Zend\Mvc\Router\Http\TranslatorAwareTreeRouteStack',
'routes' => array( /* ... */ )
)
- Also possible to use alternate console routers this way
ghost
assigned 
| */ | ||
| public function assemble(array $params = array(), array $options = array()) | ||
| { | ||
| } |
There was a problem hiding this comment.
Empty line missing after closing brace.
|
@DASPRiD ping -- added the line. |
- via @mwillbanks on IRC
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the mailing list, there's currently no way to opt-in to using the TranslatorAwareTreeRouteStack without overwriting the "Router" service. This PR fixes that situation, by allowing a new configuration item inside the router configuration, "router_class", which allows you to specify the router to use. The factory will then invoke that class'
factory()method to retrieve an instance. This can be done for either console or HTTP router types.