Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

set factory in CollectionInputFilter #4788

Conversation

tolean
Copy link
Contributor

@tolean tolean commented Jul 5, 2013

When use custom Factory for create CollectionInputFactory it contains default factory

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 35f2058 on tolean:feature/factory_in_input_filter_collection into 260205f on zendframework:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 6667cf0 on tolean:feature/factory_in_input_filter_collection into 260205f on zendframework:develop.

* @link http://github.com/zendframework/zf2 for the canonical source repository
* @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
* @package Zend_InputFilter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove @Package

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a97c551 on tolean:feature/factory_in_input_filter_collection into 260205f on zendframework:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a97c551 on tolean:feature/factory_in_input_filter_collection into 260205f on zendframework:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a97c551 on tolean:feature/factory_in_input_filter_collection into 260205f on zendframework:develop.

@mwillbanks
Copy link
Contributor

Could you please explain what this is solving? I'm attempting to figure out if this is a bug or a feature.

@tolean
Copy link
Contributor Author

tolean commented Jul 10, 2013

exemple:
Input filter specification:

array(
    'father_name' => array(
        'required' => true,
        'filters' => array(
            array(
                'name' => 'myCustomFilter'
            )
        )
    ),
    'children' => array(
        'type' => 'collection',
        'input_filter' => array(
            'name' => array(
                'required' => true,
                'filters' => array(
                    array(
                        'name' => 'myCustomFilter'
                    )
                )
            )
        )
    )
 )

myCustomFilter is registered in FilterPluginManager. Now when create input filter for father_name is ok, but for field children get the exception that unknown myCustomFilter.

@tolean tolean closed this Jul 10, 2013
@tolean tolean reopened this Jul 10, 2013
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a97c551 on tolean:feature/factory_in_input_filter_collection into 260205f on zendframework:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a97c551 on tolean:feature/factory_in_input_filter_collection into 260205f on zendframework:develop.

@richardjennings
Copy link
Contributor

@tolean is this solved by #4851 ?

@tolean
Copy link
Contributor Author

tolean commented Jul 19, 2013

@richardjennings I use a InputFilter without form for validation and filtering some data

@ghost ghost assigned weierophinney Jul 19, 2013
weierophinney added a commit that referenced this pull request Jul 19, 2013
- trailing whitespace
weierophinney added a commit that referenced this pull request Jul 19, 2013
@weierophinney
Copy link
Member

I feel this belongs on master, as it fixes behavior introduced for the 2.2 series. As such, I've cherry-picked it there, and merged to develop.

weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants