Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Possible Typo in Zend / Cache / Storage / Adapter / RedisResourceManager #4804

Closed
Rockstar04 opened this issue Jul 10, 2013 · 1 comment
Closed

Possible Typo in Zend / Cache / Storage / Adapter / RedisResourceManager #4804

Rockstar04 opened this issue Jul 10, 2013 · 1 comment
Labels
Cache EasyFix
Milestone
2.2.2

Comments

@Rockstar04
Copy link
Contributor

Zend / Cache / Storage / Adapter / RedisResourceManager :: getMayorVersion()

https://github.com/zendframework/zf2/blob/master/library/Zend/Cache/Storage/Adapter/RedisResourceManager.php#L515

Is this function really supposed to be named getMayorVersion as opposed to getMajorVersion ??
@Maks3w
Copy link
Member

Maks3w commented Jul 14, 2013

Indeed.

Please send us a contribution:

  • Copy the method with the fixed name
  • Proxy the call to the old method to the new one.
  • Add @deprecated to the docblock of the old method.

@Rockstar04 Rockstar04 mentioned this issue Jul 14, 2013
Merged
Maks3w added a commit that referenced this issue Jul 15, 2013
@Maks3w
Merge pull request #4830. Fix #4804 in develop
589f273
@Maks3w Maks3w closed this as completed in 5a5a6f1 Jul 15, 2013
Maks3w added a commit that referenced this issue Jul 15, 2013
@Maks3w
Merge pull request #4830. Fix #4804 in master
257488d
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
@Rockstar04
Correct spelling of function getMajorVersion
01ebef5 
Corrected the name of the function and provide a proxy for backwards compatibility. Refs zendframework/zendframework#4804
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
@Maks3w
Merge pull request zendframework/zendframework#4830. Fix zendframewor…
d25dc7a 
…k/zendframework#4804
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
@Maks3w
Merge pull request zendframework/zendframework#4830. Fix zendframewor…
0c9c87e 
…k/zendframework#4804 in develop
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
@Maks3w
Merge pull request zendframework/zendframework#4830. Fix zendframewor…
77fe406 
…k/zendframework#4804 in master
boesing pushed a commit to laminas/laminas-cache-storage-adapter-test that referenced this issue May 24, 2020
@Maks3w
Merge pull request zendframework/zendframework#4830. Fix zendframewor…
554b35b 
…k/zendframework#4804 in develop
boesing pushed a commit to laminas/laminas-cache-storage-adapter-apc that referenced this issue May 24, 2020
@Maks3w
Merge pull request zendframework/zendframework#4830. Fix zendframewor…
2d6b8b1 
…k/zendframework#4804 in develop
boesing pushed a commit to laminas/laminas-cache-storage-adapter-redis that referenced this issue Jul 5, 2020
@Maks3w
Merge pull request zendframework/zendframework#4830. Fix zendframewor…
0751e93 
…k/zendframework#4804 in develop
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Cache EasyFix
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
2 participants
@Rockstar04 @Maks3w