This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Unimplemented REST methods should set a 405 status #4808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2013 13:44
…in AbstractRestfulController Since no method is mandatory in REST, AbstractRestfulController shouldn't force to implement these methods (create, delete, get, getList and update) thus conducing to a concrete class with empty/unused methods.
|
Please add in unit tests to verify the behavior. |
|
My bad, should have done that. |
ghost
assigned 
|
Great idea -- wish I'd thought of this before! |
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
|
It looks better, but stated in rfc regarding 405 status: "...The response MUST include an Allow header containing a list of valid methods for the requested resource." |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unimplemented http methods now set a 405 status