This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow FormElementErrors view helper to translate messages #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2013
| array_walk_recursive($messages, function ($item) use (&$messagesToPrint, $escapeHtml, $self) { | ||
| if (null !== ($translator = $self->getTranslator())) { | ||
| $item = $translator->translate( | ||
| $item, $self->getTranslatorTextDomain() |
There was a problem hiding this comment.
One argument per line if you're going to do multiple lines; otherwise, move to the line where the call is made.
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
Allow FormElementErrors view helper to translate messages
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
- Incorrect assumption in one test led to a failure; fixed. - Minor CS changes for array notation, method arguments
ghost
assigned 
|
I incorporated feedback on merge. Thanks, @RalfEggert ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow FormElementErrors view helper to translate messages
Please ignore PRs 4671 and 4672