Tests for issue with unexpected injection.

[spalax]

Test for Issue #4862

[spalax]

"pull request" one more time, to propose it from a branch.

[weierophinney]

@spalax will you be working on the fix for this as well?

[samsonasik]

remove @Package

[samsonasik]

@spalax : @Package docblock should be deleted, yes, in other files at tests folder, it should be deleted too ^^

[spalax]

@weierophinney : yes i will work to fix it.

[spalax]

@samsonasik : if i remove @Package docblock in all other assets inside DI, should i pul it as new one pull request ?

[samsonasik]

For this PR, you should only delete what I've mentioned, make new commit and push to this branch, you can make new branch and make new PR for other specific issue :)

[spalax]

@samsonasik: thanks for details.

[weierophinney]

@spalax Tests are looking good -- any ETA on getting a fix in place?

[spalax]

I do not really sure if i not broke some thing else, i passed thru tests in DI folder successfully. Please review my changes details because there is quite hard logic in method resolveMethodParameters. Would be cool to refactor DI class, or at least refactor resolveMethodParameters (300 lines of codes and a lot of nested cycles it is tough)

[weierophinney]

@spalax it looks good -- your test fails before applying the change, and passes afterwards. If there is other breakage, it means the newly broken functionality was not previously tested. :)