This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Notices being triggered when hydrating classes with no properties with the reflection hydrator #4919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anybody having an idea why the notice shown at https://travis-ci.org/Ocramius/zf2/jobs/9711636#L800 is not causing a failure? |
7 tasks
|
@weierophinney though the failure is not triggered @7fc7219, this is mergeable |
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Aug 19, 2013
Notices being triggered when hydrating classes with no properties with the reflection hydrator
weierophinney
added a commit
that referenced
this pull request
Aug 19, 2013
- Updated docblocks to remove `@static` annotation and to align properties (to be consistent with rest of class). - Return early when cached values are present, thus promoting the meat of the method to the method body.
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…fix/reflection-hydrator-notice Notices being triggered when hydrating classes with no properties with the reflection hydrator
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
- Updated docblocks to remove `@static` annotation and to align properties (to be consistent with rest of class). - Return early when cached values are present, thus promoting the meat of the method to the method body.
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.