This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Undefined variable: class in Zend/ModuleManager/Listener/ServiceListener.php #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rviceListener.php
| @@ -244,7 +244,7 @@ protected function serviceConfigToArray($config) | |||
| if (!$config instanceof ServiceConfig) { | |||
| throw new Exception\RuntimeException(sprintf( | |||
| 'Invalid service manager configuration class provided; received "%s", expected an instance of Zend\ServiceManager\Config', | |||
| $class | |||
| is_object($config) ? get_class($config) : (is_scalar($config) ? $config : gettype($config)) | |||
There was a problem hiding this comment.
This needs to be wrapped in parens to work.
|
I didn't know about this convention. |
|
@coolmic I think @weierophinney simply didn't see a comma |
|
@Ocramius Actually, no, it was a syntax issue. Parens are needed if you use a ternary to return a value as part of an function/method argument; I know, because I got bit by it some time back. :) |
ghost
assigned
|
Cherry-picked to master for release with 2.2.3. |
weierophinney
added a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce error :
Add in config
Well, it's a little useless because I fix an error, that occur on fatal error, but the exception message is at least more readable.