ZendCode - allow const and property of same name

[Danack]

Hi,

PHP allows classes to have properties and consts of the same name, but ZendCode doesn't support this.

use Zend\Code\Reflection\ClassReflection;
use Zend\Code\Generator\ClassGenerator;
use Zend\Code\Generator\MethodGenerator;
use Zend\Code\Generator\PropertyGenerator;


require_once('../vendor/autoload.php');


class OutputClass
{
    private $x = "I'm not sure why,";

    const x = ' would I ever want this?';

    function foo() {
        echo $this->x;
        echo self::x;
    }
}

$test = new OutputClass();

$test->foo();

$reflector = new ClassReflection('OutputClass');
$classGenerator = ClassGenerator::fromReflection($reflector);
$methods = $reflector->getMethods();

foreach ($methods as $method) {
    $methodGenerator = MethodGenerator::fromReflection($method);
    $classGenerator->addMethodFromGenerator($methodGenerator);
}

$constants = $reflector->getConstants();
foreach ($constants as $name => $value) {
    $classGenerator->addProperty($name, $value, PropertyGenerator::FLAG_CONSTANT);
}

$properties = $reflector->getProperties();
foreach ($properties as $property) {
    $classGenerator->addPropertyFromGenerator($property);
}

$text = $classGenerator->generate();
echo $text;

Outputs:

I'm not sure why, would I ever want this?
PHP Fatal error: Uncaught exception 'Zend\Code\Generator\Exception\InvalidArgumentException' with message 'A property by name x already exists in this class.' in /somedir/vendor/zendframework/zend-code/Zend/Code/Generator/ClassGenerator.php:475
F

[Danack]

Tested against head. The issue is still there, but the code example above doesn't work. Here is a new example that shows the issue:

use Zend\Code\Reflection\ClassReflection;
use Zend\Code\Generator\ClassGenerator;
use Zend\Code\Generator\MethodGenerator;
use Zend\Code\Generator\PropertyGenerator;


require_once('./vendor/autoload.php');


class OutputClass
{
    private $x = "I'm not sure why,";

    const x = ' would I ever want this?';

    function foo() {
        echo $this->x;
        echo self::x;
    }
}

$test = new OutputClass();

$test->foo();

$reflector = new ClassReflection('OutputClass');
$classGenerator = ClassGenerator::fromReflection($reflector);


$constants = $reflector->getConstants();
foreach ($constants as $name => $value) {
    $classGenerator->addProperty($name, $value, PropertyGenerator::FLAG_CONSTANT);
}

$text = $classGenerator->generate();
echo $text;

Also note that ClassGenerator::fromReflection($reflector); isn't adding the constant.

[steverhoades]

@Danack Please see my latest branch for this issue: https://github.com/steverhoades/zf2/tree/hotfix/6274. If you could please let me know if this resolves your issue I would appreciate it.

• Steve

[Danack]

Hi Steve,

Yep that branch works fine for this issue.

cheers
Dan

[Ocramius]

Handled in #6288