Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

I18n/Validator/DateTime should use mb_strlen() instead of strlen() #6321

Closed
bacinsky opened this issue May 23, 2014 · 2 comments · Fixed by #6311
Closed

I18n/Validator/DateTime should use mb_strlen() instead of strlen() #6321

bacinsky opened this issue May 23, 2014 · 2 comments · Fixed by #6311
Assignees
@weierophinney
Labels
bug EasyFix I18n
Milestone
2.3.2

Comments

@bacinsky
Copy link
Contributor

https://github.com/zendframework/zf2/blob/develop/library/Zend/I18n/Validator/DateTime.php#L283
This is failing with utf-8 characters.

Or use less than, maybe.
@DASPRiD
Copy link
Member

DASPRiD commented May 23, 2014

We already had a PR for this, but it was closed due to inactivity of the author after changes were suggested: #5619

@moderndeveloperllc
Copy link
Contributor

@bacinsky There is a current PR in for this right now: #6311. It should be accepted reasonably soon.

@moderndeveloperllc moderndeveloperllc mentioned this issue May 24, 2014
Merged
@Ocramius Ocramius added this to the 2.3.2 milestone Aug 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weierophinney weierophinney

Labels
bug EasyFix I18n
Projects
None yet
Milestone
2.3.2
Development

Successfully merging a pull request may close this issue.

Fixes #6297: Fixes logic that checks if IntlDateFormatter parsed the string properly.
5 participants
@weierophinney @Ocramius @DASPRiD @moderndeveloperllc @bacinsky