Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Priority system for validators #6386

Closed
weierophinney opened this issue Jun 17, 2014 · 5 comments
Closed

Priority system for validators #6386

weierophinney opened this issue Jun 17, 2014 · 5 comments
Assignees
@Ocramius
Labels
duplicate enhancement Validator
Milestone
2.4.0

Comments

@weierophinney
Copy link
Member

The Zend\Filter\FilterChain class allows you to prioritize filters, and uses Zend\Stdlib\PriorityQueue internally. Zend\Validator\ValidatorChain should do this as well. The prepend*() methods would check for the highest priority value, and add one to it, while attach*() would assume default priority unless a priority value is provided.
@MadCat34
Copy link
Contributor

Ok for a PR ?

@Ocramius
Copy link
Member

@weierophinney why would the order of validators matter? Unless we have a concept of "break chain on success", I see little use-cases for this.

@Ocramius
Copy link
Member

Nvm, I see some value in configurability, though a "break chain on success" would be totally awesome :-)

@localheinz
Copy link
Member

👍

@MadCat34 MadCat34 mentioned this issue Jul 29, 2014
Closed
@adamlundrigan
Copy link
Contributor

@Ocramius this PR was replaced by #6496 and so can be closed

@Ocramius Ocramius self-assigned this Nov 19, 2014
@Ocramius Ocramius added this to the 2.4.0 milestone Nov 19, 2014
Ocramius pushed a commit that referenced this issue Nov 19, 2014
@MadCat34 @Ocramius
#6386 Add Priority system for validators
72f264d
Ocramius added a commit that referenced this issue Nov 19, 2014
@Ocramius
#6496 #6386 - validator chain should reject invalid callbacks
1c72791
Ocramius added a commit that referenced this issue Nov 19, 2014
@Ocramius
#6496 #6386 - minor cleanups, simplifying checks around $callback v…
3f7ced5 
…alidity
Ocramius added a commit that referenced this issue Nov 19, 2014
@Ocramius
#6496 #6386 - adding @group annotations for newly introduced tests
93992f0
Ocramius added a commit that referenced this issue Nov 19, 2014
@Ocramius
#6496 #6386 - inlining $this->attach() and $this->plugin() calls
53aa76f
Ocramius added a commit that referenced this issue Nov 19, 2014
@Ocramius
#6496 #6386 - reverting minor bc-break (attach method should keep a…
9244b02 
… compatible signature)
Ocramius added a commit that referenced this issue Nov 19, 2014
@Ocramius
#6496 #6386 - removing useless test that checks against an invalid ty…
ceded40 
…pe-hint usage
Ocramius added a commit that referenced this issue Nov 19, 2014
@Ocramius
#6496 #6386 - reverting unrelated test changes
d0001c8
Ocramius added a commit that referenced this issue Nov 19, 2014
@Ocramius
Merge branch 'feature/#6386-#6496-support-validator-priority' into de…
18f8762 
…velop

Close #6386
Close #6496
Ocramius added a commit to Ocramius/zf2 that referenced this issue Nov 22, 2014
@Ocramius
zendframework#6386 zendframework#6496 - adding test for uncovered `Va…
ab6cd16 
…lidatorChain#merge()` method, which presents internal type mismatches
Ocramius added a commit to Ocramius/zf2 that referenced this issue Nov 22, 2014
@Ocramius
zendframework#6386 zendframework#6496 - fixing values passed internal…
ae6a7c6 
…ly to `ValidatorChain#attach()` by `ValidatorChain#merge()`
This was referenced Nov 22, 2014
Closed
Closed
Merged
Ocramius added a commit to Ocramius/zf2 that referenced this issue Nov 22, 2014
@Ocramius
zendframework#6386 zendframework#6496 - ValidatorChain must be clon…
300a4b1 
…eable
Ocramius added a commit to Ocramius/zf2 that referenced this issue Nov 22, 2014
@Ocramius
zendframework#6386 zendframework#6496 - ValidatorChain can be clone…
b95a49c 
…d, as the validator chain is now deep-cloned
Ocramius added a commit that referenced this issue Nov 22, 2014
@Ocramius
Merge pull request #6912 from Ocramius/hotfix/#6386-#6496-validator-c…
a6ec0bd 
…hain-merge-type-mismatch

Hotfix: #6386 #6496 validator chain merge type mismatch
@MadCat34 MadCat34 mentioned this issue Nov 25, 2014
Closed
Ocramius pushed a commit to zendframework/zf2-documentation that referenced this issue Nov 26, 2014
@Ocramius
Add example : Priority system for validators (see zendframework/zendf…
7e09797 
…ramework#6386)
samsonasik pushed a commit to samsonasik/zf2-documentation that referenced this issue Mar 31, 2015
@samsonasik
Add example : Priority system for validators (see zendframework/zendf…
ade8a20 
…ramework#6386)
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@MadCat34 @Ocramius
zendframework/zendframework#6386 Add Priority system for validators
fb5b8b9
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - v…
d533dcb 
…alidator chain should reject invalid callbacks
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - m…
f0c42b7 
…inor cleanups, simplifying checks around `$callback` validity
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - a…
0cc783e 
…dding `@group` annotations for newly introduced tests
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - i…
d570801 
…nlining `$this->attach()` and `$this->plugin()` calls
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - r…
eeb8fb9 
…everting minor bc-break (`attach` method should keep a compatible signature)
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - r…
8e4e1ba 
…emoving useless test that checks against an invalid type-hint usage
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6496 zendframework/zendframework#6386 - r…
4ac44d6 
…everting unrelated test changes
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
Merge branch 'feature/zendframework/zendframework#6386-zendframework/…
9b5e8eb 
…zendframework#6496-support-validator-priority' into develop

Close zendframework/zendframework#6386
Close zendframework/zendframework#6496
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6386 zendframework/zendframework#6496 - a…
a639c2e 
…dding test for uncovered `ValidatorChain#merge()` method, which presents internal type mismatches
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6386 zendframework/zendframework#6496 - f…
c15d5d6 
…ixing values passed internally to `ValidatorChain#attach()` by `ValidatorChain#merge()`
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6386 zendframework/zendframework#6496 - `…
a19c484 
…ValidatorChain` must be cloneable
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6386 zendframework/zendframework#6496 - `…
9ba3524 
…ValidatorChain` can be cloned, as the validator chain is now deep-cloned
gianarb pushed a commit to zendframework/zend-validator that referenced this issue May 15, 2015
@Ocramius
Merge pull request zendframework/zendframework#6912 from Ocramius/hot…
34571c8 
…fix/zendframework/zendframework#6386-zendframework/zendframework#6496-validator-chain-merge-type-mismatch

Hotfix: zendframework/zendframework#6386 zendframework/zendframework#6496 validator chain merge type mismatch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
duplicate enhancement Validator
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
5 participants
@weierophinney @Ocramius @adamlundrigan @localheinz @MadCat34