Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

conflicting PHPDoc @return values in SharedEventManager #6511

Closed
dorongutman opened this issue Aug 2, 2014 · 1 comment
Closed

conflicting PHPDoc @return values in SharedEventManager #6511

dorongutman opened this issue Aug 2, 2014 · 1 comment
Assignees
@Ocramius
Labels
enhancement EventManager
Milestone
2.3.2

Comments

@dorongutman
Copy link
Contributor

The interface SharedEventManagerInterface (well, the PHPDoc in it) defines the return value of the attach method to be void (https://github.com/zendframework/zf2/blob/master/library/Zend/EventManager/SharedEventManagerInterface.php#L36), whereas the only implementation of it always returns something (either CallbackHandler or an array) - https://github.com/zendframework/zf2/blob/master/library/Zend/EventManager/SharedEventManager.php#L60
@gianarb
Copy link
Contributor

gianarb commented Aug 2, 2014

Oh yes would your fix it with a PR?

dorongutman added a commit to dorongutman/zf2 that referenced this issue Aug 2, 2014
@dorongutman
fixed conflicted phpdoc return values (see zendframework#6511
c644e64
@dorongutman dorongutman mentioned this issue Aug 2, 2014
Closed
@Ocramius Ocramius added this to the 2.3.2 milestone Aug 2, 2014
@Ocramius Ocramius self-assigned this Aug 2, 2014
Ocramius pushed a commit that referenced this issue Aug 6, 2014
@dorongutman @Ocramius
fixed conflicted phpdoc return values (see #6511
fbceafc
Ocramius added a commit that referenced this issue Aug 6, 2014
@Ocramius
Merge branch 'hotfix/#6512-fix-#6511-sharedeventmanager-return-values…
0725016 
…-phpdoc' into develop

Forward port #6512
Forward port #6511
gianarb pushed a commit to zendframework/zend-eventmanager that referenced this issue May 15, 2015
@dorongutman @Ocramius
fixed conflicted phpdoc return values (see zendframework/zendframewor…
3aa5155 
…k#6511
gianarb pushed a commit to zendframework/zend-eventmanager that referenced this issue May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6512-fix-zendframewo…
2e55551 
…rk/zf2#6511-sharedeventmanager-return-values-phpdoc'

Close zendframework/zendframework#6512
Close zendframework/zendframework#6511
gianarb pushed a commit to zendframework/zend-eventmanager that referenced this issue May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6512-fix-zendframewo…
2999ccd 
…rk/zf2#6511-sharedeventmanager-return-values-phpdoc' into develop

Forward port zendframework/zendframework#6512
Forward port zendframework/zendframework#6511
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
enhancement EventManager
Projects
None yet
Milestone
2.3.2
Development

No branches or pull requests
3 participants
@Ocramius @dorongutman @gianarb