Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Exception thrown when value_options is empty in Form\View\ViewHelper\FormMultiCheckbox #6649

Closed
monkeyphp opened this issue Sep 8, 2014 · 3 comments
Closed

Exception thrown when value_options is empty in Form\View\ViewHelper\FormMultiCheckbox #6649

monkeyphp opened this issue Sep 8, 2014 · 3 comments
Assignees
@Ocramius
Labels
bug Form
Milestone
2.3.4

Comments

@monkeyphp
Copy link
Contributor

I don't know if this could be considered a bug - but I don't understand why an exception would need to be thrown in the valueOptions property is empty.

https://github.com/zendframework/zf2/blob/master/library/Zend/Form/View/Helper/FormMultiCheckbox.php#L113

Surely, there is a valid use case (say for DB backed forms) where no value options is perfectly acceptable.
@samsonasik
Copy link
Contributor

@monkeyphp yes I think. PR ?

@monkeyphp
Copy link
Contributor Author

I have created a PR for this #6655

Ocramius added a commit that referenced this issue Dec 30, 2014
@Ocramius
#6649 #6655 - rendering a multicheckbox without value options should …
4ea169e 
…produce an empty string
Ocramius added a commit that referenced this issue Dec 30, 2014
@Ocramius
#6649 #6655 - adding @group annotations for newly introduced tests
eb4cc8c
Ocramius added a commit that referenced this issue Dec 30, 2014
@Ocramius
Merge branch 'hotfix/#6655-#6649-allow-empty-form-element-value-optio…
5bbb449 
…ns-in-form-element-renderer' into develop

Close #6655
Close #6649
Forward port #6655
Forward port #6649
@Ocramius Ocramius self-assigned this Dec 30, 2014
@Ocramius Ocramius added this to the 2.3.4 milestone Dec 30, 2014
@Ocramius
Copy link
Member

Fixed in #6655

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
bug Form
Projects
None yet
Milestone
2.3.4
Development

No branches or pull requests
3 participants
@Ocramius @samsonasik @monkeyphp