Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Remove PHPCov dependency via VCS composer repository #6734

Closed
Ocramius opened this issue Oct 4, 2014 · 13 comments
Closed

Remove PHPCov dependency via VCS composer repository #6734

Ocramius opened this issue Oct 4, 2014 · 13 comments
Assignees
Milestone

Comments

@Ocramius
Copy link
Member

Ocramius commented Oct 4, 2014

See https://github.com/zendframework/zf2/blob/f77f90bfe635a762d1a89469fe846585d636a89f/composer.json#L11

Unless we REALLY need the exact version of sebastianbergmann/phpcov:1.1.0, then this dep can go away, and we can rely on the packagist repo phpunit/phpcov

Assigning to @DASPRiD since I can't work on this until monday.

/cc @Seldaek

@DASPRiD
Copy link
Member

DASPRiD commented Oct 4, 2014

We don't rely on it, but back then, there was no packagist entry.

@Ocramius
Copy link
Member Author

Ocramius commented Oct 4, 2014

I suppose we can bump to 2.0.* and remove the VCS package then

@DASPRiD
Copy link
Member

DASPRiD commented Oct 4, 2014

AFAIK the command line arguments changed in the 2.* series, so we also need to update the calls to it then.

@samsonasik
Copy link
Contributor

as I tried at #6835 by issue I created at #6829 for coveralls error, when using sebastianbergmann/phpcov:1.1.0 from VCS as current, it gives errror :

php vendor/bin/phpcov.php --merge --clover build/logs/clover.xml --whitelist library build/coverage

PHP Warning: require(PHP/CodeCoverage/Autoload.php): failed to open stream: No such file or directory in /home/travis/build/zendframework/zf2/vendor/sebastianbergmann/phpcov/src/autoload.php on line 44

PHP Stack trace:

PHP 1. {main}() /home/travis/build/zendframework/zf2/vendor/sebastianbergmann/phpcov/phpcov.php:0

PHP 2. require() /home/travis/build/zendframework/zf2/vendor/sebastianbergmann/phpcov/phpcov.php:46

as @DASPRiD said, 1.1.0 didn't have packagist entry yet. So, I give a try to use sebastianbergmann/phpcov version 2.0.* from packagist that it require phpunit 4.3.4 and it makes error :

Warning: Unexpected character in input:  ' in /home/travis/build/zendframework/zf2/vendor/phpunit/php-token-stream/src/Token/Stream.php on line 195

and re-tried by using phpcov.phar got error :

$ php phpcov.phar merge --clover build/logs/clover.xml build/coverage

phpcov 2.0.1 by Sebastian Bergmann.

O:16:"PHP_CodeCoverage":10:{s:9:"*driver";O:30:"PHP_CodeCoverage_Driver_Xdebug":0:{}s:9:"*filter";O:23:"PHP_CodeCoverage_Filter":3:{s:19:"*blacklistedFiles";a:256:{s:93:"/home/travis/build/zendframework/zf2/tests/ZendTest/Code/Annotation/AnnotationManagerTest.php";b:1;s:90:"/home/travis/build/zendframework/zf2/vendor/phpunit/phpunit/PHPUnit/Framework/TestCase.php";b:1;s:88:"/home/travis/build/zendframework/zf2/vendor/phpunit/phpunit/PHPUnit/Framework/Assert.php";b:1;s:87:"/home/travis/build/zendframework/zf2/vendor/phpunit/php-file-iterator/File/Iterator.php";b:1;s:96:"/home/travis/build/zendframework/zf2/vendor/phpunit/php-file-iterator/File/Iterator/Autoload.php";b:1;s:94:"/home/travis/build/zendframework/zf2/vendor/phpunit/php-file-iterator/File/Iterator/Facade.php";b:1;s:95:"/home/travis/build/zendframework/zf2/vendor/phpunit/php-file-iterator/File/Iterator/Factory.php";b:1;s:90:"/home/travis/build/zendframework/zf2/vendor/phpunit/php-code-coverage/PHP/CodeCoverage.php";b:1;s:99:"/home/travis/build/zendframework/zf2/vendor/phpunit/php-code-coverage/PHP/CodeCoverage/Autoload.php";b:1;s:97:"/home/travis/build/zendframework/zf2/vendor/phpunit/php-code-coverage/PHP/CodeCoverage/Driver.php";b:1;s:104:"/home/travis/build/zendframework/zf2/vendor/phpunit/php-code-coverage/PHP/CodeCoverage/Driver/Xdebug.php";b:1;s:100:"/home/travis/build/zendframework/zf2/vendor/phpunit/php-code-coverage/PHP/CodeCoverage

and then the coveralls won't generated.

@Ocramius
Copy link
Member Author

Ocramius commented Nov 5, 2014

We should probably kill coveralls and use https://github.com/scrutinizer-ci/ocular instead

@samsonasik
Copy link
Contributor

@Ocramius do zf2 repo already registered at scrutinizer ?

@Ocramius
Copy link
Member Author

Ocramius commented Nov 5, 2014

Not by the organization :-\

@samsonasik
Copy link
Contributor

anyone have access to register it ?

@Ocramius
Copy link
Member Author

@samsonasik only @weierophinney can do that, though I can probably bribe @schmittjoh <_<

@schmittjoh
Copy link

:)

We could add it ofc, but it would never fully work without someone setting it up with admin access to the Zend repository. To just get results once, I'd rather suggest running Scrutinizer on a fork.

@Ocramius
Copy link
Member Author

@schmittjoh I'll blackmail people in the Zend team then :-)

@samsonasik
Copy link
Contributor

@Ocramius I think it can be closed based on based on #6909

@Ocramius
Copy link
Member Author

Indeed, thanks!

@Ocramius Ocramius assigned Ocramius and unassigned DASPRiD Nov 30, 2014
@Ocramius Ocramius added this to the 2.4.0 milestone Nov 30, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants