pg_connect params encodings

[ishenkoyv]

https://github.com/zendframework/zf2/blob/master/library/Zend/Db/Adapter/Driver/Pgsql/Connection.php#LC180

$connection = http_build_query($connection, null, ' '); // @link http://php.net/pg_connect

I can't connect to postgres if params contain special symbols, e.g. '!' as connection string represents them in url encoded way.
So if my config db section looks like

'db' => array(
    'adapters' => array(
        'db' => array(
            'driver'    => 'pgsql',
            'host' => 'localhost',
            'post' => '5432',
            'dbname' => 'test',
            'username'  => 'test',
            'password'  => 'test123',
        ),
    ),
),

the produced connection string will be
'host=localhost user=test password=test123%21 dbname=test'

There is link to http://php.net/pg_connect in code but really I don't understand what I should find there.
Is there reason to use http_build_query against connection string through the connection method for psql driver or it's a legacy code which should be removed?

Best regards

[jeremyquinton]

The example configuration you have given for
'password' => 'test123' I think you intended to write
'password' => 'test123!'

This certainly is pretty limiting and can be improved upon as passwords can contain symbols. I also find the use of http_build_query quite interesting.

[samsonasik]

@ishenkoyv @jeremyquinton I created PR #6787 for it

[jeremyquinton]

👍

[Ocramius]

Handled in #6787