This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix bugs for some locales! #3746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not a Regex expert but at least the stripos(') === false makes sense. If there are no more errors... let's do that! |
|
@wryck7 Could you perhaps also provide a unit test? That will ensure this issue is fixed permanently. |
added 4 commits
February 11, 2013 02:20
I had to change this too because this class overwrites the parsePattern() method.
|
@bacura10! Can you take a look at everything to make sure it is all good! |
|
Looks good to me. Can be merged :). |
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fix some bugs for locales like pt_BR, es_ES and ru!
This is a continuation of the issue #3694