-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Update EM->trigerUntil to be an alias of trigger #4122
Update EM->trigerUntil to be an alias of trigger #4122
Conversation
They contained the exact same code/logic. The only difference was the conditional around checking if the callback was valid, but the outcome is the same for both. This simply reduces duplicate code and causes no change in behavior at all.
The method |
Agree with @marc-mabe . Please deprecate the triggerUntil method |
} | ||
|
||
return $this->triggerListeners($event, $e, $callback); | ||
trigger_error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll either have to update the tests that call triggerUntil()
to ignore the warning, or remove them; the test suite breaks mightily currently!
ping @EvanDotPro ... fix the deprecation notices... :) |
Closing due to inactivity. @EvanDotPro feel free to re-open or open a new PR when you're able to fix the issues. |
Please reactivate this issue as triggerUntil has additional flaws: The signature states |
Marked as a BC break, as it emits a deprecation notice (which can and does break unit tests on code that exercises the method!). |
…eventmanager-triggeruntil' into develop Close zendframework/zendframework#6613 Close zendframework/zendframework#4122
…eventmanager-triggeruntil' into develop Close zendframework/zendframework#6613 Close zendframework/zendframework#4122
They contained the exact same code/logic. The only difference was the
conditional around checking if the callback was valid, but the outcome
is the same for both. This simply reduces duplicate code and causes no
change in behavior at all.