This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Add Config Reader for Java-style .properties files and strings #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 13, 2013 15:00
| * @link http://github.com/zendframework/zf2 for the canonical source repository | ||
| * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com) | ||
| * @license http://framework.zend.com/license/new-bsd New BSD License | ||
| * @package Zend_Config |
1 similar comment
|
|
||
| namespace ZendTest\Config\Reader; | ||
|
|
||
| use Zend\Config\Reader\JavaProperties as JavaProperties; |
|
|
||
| // Check if ends with single '\' (indicating another line is expected) | ||
| if (strrpos($value, "\\") === strlen($value)-strlen("\\")) { | ||
| $value = substr($value,0,strlen($value)-1); |
There was a problem hiding this comment.
Spaces after comma and before and after minus.
1 similar comment
| * | ||
| * @see ReaderInterface::fromString() | ||
| * @param string $string | ||
| * @return array|bool |
There was a problem hiding this comment.
While reading this code, it seems to me that this ::fromString() method never returns a boolean. Therefore I would suggest removing that hint. I would also suggest adding an @throws line, since the ::process() method can throw an exception.
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Jul 22, 2013
…perties Add Config Reader for Java-style .properties files and strings
weierophinney
added a commit
that referenced
this pull request
Jul 22, 2013
| } | ||
|
|
||
| // Check if ends with single '\' (indicating another line is expected) | ||
| if (strrpos($value, "\\") === strlen($value) - strlen("\\")) { |
There was a problem hiding this comment.
Maybe it's better to get strlen("\\") out of the cycle?
There was a problem hiding this comment.
Like, replacing it with 1? I agree.
weierophinney
added a commit
to zendframework/zend-config
that referenced
this pull request
May 15, 2015
…ature/config-reader-javaproperties Add Config Reader for Java-style .properties files and strings
weierophinney
added a commit
to zendframework/zend-config
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a Config Reader for Java-style .properties files and strings with corresponding tests.